feat: add detailed steps and timeline for Philippines 13A visa application process#456
Open
gabconcepcionph wants to merge 8 commits into
Open
Conversation
Collaborator
|
@gabconcepcionph Can this be an accordion instead? This would ensure that each step has more details and the user doesn't have to scroll too much. Feel free to use this doc as reference: https://ui.shadcn.com/docs/components/accordion |
DaijobuDes
requested changes
Oct 15, 2025
| @@ -0,0 +1,85 @@ | |||
| import { expect, test } from '@playwright/test'; | |||
|
|
|||
| test.describe('Philippine visa types', () => { | |||
Member
There was a problem hiding this comment.
Suggested change
| test.describe('Philippine visa types', () => { |
Since tests do not share contexts, this should be safe to remove. It's best to use test.describe() when creating tests with shared contexts.
Member
There was a problem hiding this comment.
Please refrain from using the locator() method and manually specifying the HTML tags or xpath to locate an element. Please use the getByRole() method instead.
locator() is best used when you are trying to narrow down elements to locate then paired with getByRole()
angelofallars
added
needs-content-review
mid priority
…epcionph/bettergov into feature/visa-steps-structured-ui
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing
npx playwright test e2e/travel/visa-types.spec.tsWith steps
Without steps
